Open
Conversation
weiminyu
force-pushed
the
java-25
branch
3 times, most recently
from
a15f54a to
fcdde6b
Compare
gbrodman
approved these changes
Apr 2, 2026
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 25 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on weiminyu).
Error-prone introduced many more checks in Java 25. We fixed a few
and suppressed most. A follow-up bug is opened to clean this up.
An ai agent should be able to clean up most of it.
This PR is created with gemini-cli. Summary of experience:
* The good: AI caught most compatibility issues, and with permission,
suppressed them through compiler flags and errorprone options.
It also caught many versio references in scripts.
* Where it didn't shine:
- It did not find and update the target version spec in the custome
VKey annotation processor source file.
- It did not flag eclipse-temurin:21 docker image for upgrade.
- When running into failure, its first instinct is to disable checks
e.g., -Werror instead of fixing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source/Target Compatibility Levels are kept to VERSION_21. Along with a minor change in VKeyProcessor, these allow both Java 21 and 25 to build nomulus. Putting Java 25 on Kokoro will take a little time.
Error-prone introduced many more checks in Java 25. We fixed a few and suppressed most. A follow-up bug is opened to clean this up. An ai agent should be able to clean up most of it.
This PR is created with gemini-cli. Summary of experience:
The good: AI caught most compatibility issues, and with permission, suppressed them through compiler flags and errorprone options. It also caught many version references in various shell and docker scripts.
Where it didn't shine:
This change is